This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Youtube element improvements #8183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -78,7 +78,7 @@ protected function compile() | |||
|
|
|||
| $objFile = new \stdClass(); | |||
| $objFile->mime = 'video/x-youtube'; | |||
| $objFile->path = '//www.youtube.com/watch?v=' . $this->youtube; | |||
| $objFile->path = 'https://www.youtube.com/watch?v=' . $this->youtube; | |||
There was a problem hiding this comment.
Because we should always use secure URLs if available.
There was a problem hiding this comment.
BTW: we did have this discussion already like 4 times :D
|
We should generally use the iframe embedding in the future (also see #8217). |
|
I still think this should make it into 3.5 … |
|
+1 |
|
Fixed in fd168c3. |
leofeyer
added a commit
that referenced
this pull request
Mar 21, 2016
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Mar 26, 2016
### 4.1.2 (2016-03-22) * Handle derived classes in the exception converter (see #462). * Prevent the autofocus attribute from being added multiple times (see contao/core#8281). * Respect the SSL settings of the root page when generating sitemaps (see contao/core#8270). * Read from the temporary file if it has not been closed yet (see contao/core#8269). * Always use HTTPS if the target server supports SSL connections (see contao/core#8183). * Adjust the meta wizard field length to the column length (see contao/core#8277). * Correctly handle custom mime icon paths (see contao/core#8275). * Show the 404 error page if an unpublished article is requested (see contao/core#8264). * Correctly count the URLs when rebuilding the search index (see contao/core#8262). * Ensure that every image has a width and height attribute (see contao/core#8162). * Set the correct mime type when embedding SVG images (see contao/core#8245). * Handle the "float_left" and "float_right" classes in the back end (see contao/core#8239). * Consider the fallback language if a page alias is ambiguous (see contao/core#8142). * Fix the error 403/404 redirect (see contao/website#74).
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.