This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Let Environment::requestUri() handle absolute URI #8661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Contaoists!
Method Environment::requestUri relys on the $_SERVER['REQUEST_URI'] variable containing a URI only in relative-form.
In rfc 7230 section 5.3.2 it's demanded that a "server MUST accept the absolute-form in requests, even though HTTP/1.1 clients will only send them in requests to proxies." Therefore $_SERVER['REQUEST_URI'] may contain a full valid URL including scheme. This happens for instance when using a SSH tunnel as HTTP Proxy, where GET request line doesn't get rewritten as in HTTP Proxies for that purpse.
This has an subsequent effect on e.g. the generation of the action attribute in the backend login form, resulting in an url-encoded full URL (http%3A//...) and disabling login.
May I suggest stripping the hostname and scheme if present?
Regards
Martin