Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview maintenance mode locally #78

Closed
m-vo opened this issue Jul 20, 2018 · 2 comments
Closed

Preview maintenance mode locally #78

m-vo opened this issue Jul 20, 2018 · 2 comments
Assignees
Labels
Milestone

Comments

@m-vo
Copy link
Member

m-vo commented Jul 20, 2018

In 423a683 the default configuration for authorized ips (lexik maintenance bundle) has been set to ['127.0.0.1'] as a quick fix for contao/core-bundle#1492.

How am I supposed to test the maintenance mode locally now (e.g. when working on a custom service_unavailable template) besides temporarily removing the setting again in my config like so (with the implications of the referenced ticket)?

lexik_maintenance:
    authorized:
        ips: []

btw.: The related PR in Symfony symfony/symfony#27309 that was in the way and leaded to the quickfix has been merged in 3.4.12.

@leofeyer leofeyer added the bug label Jul 23, 2018
@leofeyer leofeyer added this to the 4.4.21 milestone Jul 23, 2018
@leofeyer
Copy link
Member

We can revert the intermediate fix now.

@leofeyer
Copy link
Member

Reverted in 5768cfe.

@leofeyer leofeyer self-assigned this Aug 13, 2018
@leofeyer leofeyer modified the milestones: 4.4.21, 4.4 May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants