[RTM] Enable the FOS cache bundle #67
Conversation
Toflar
changed the title
|
FOSCacheBundle 2.3 has been released, this PR is ready to be merged. |
|
This is not possible because the interface only has a |
| { | ||
| $kernel = $this->mockKernel($this->getTempDir()); | ||
|
|
||
| $this->assertInstanceOf(HttpCacheProvider::class, $kernel); |
There was a problem hiding this comment.
This test should go into the testInstantiation() method.
| */ | ||
| public function __construct(KernelInterface $kernel, string $cacheDir = null) | ||
| public function __construct(ContaoKernel $kernel, string $cacheDir = null) |
There was a problem hiding this comment.
I don't like this. Why don't we use HttpCacheAware instead?
There was a problem hiding this comment.
There is no HttpCacheAware?
There was a problem hiding this comment.
There was a problem hiding this comment.
That's a trait, you can't typehint a trait?
There was a problem hiding this comment.
Yeah, which is exactly what we want. You shouldn't be able to use a different kernel other than ContaoKernel for ContaoCache. We cannot typehint for an interface either :)
There was a problem hiding this comment.
You shouldn't be able to use a different kernel other than
ContaoKernel
Why not?
There was a problem hiding this comment.
Because it's our cache with our kernel? If you want to do something else, you're very likely not only adjusting the kernel but also the cache. Also, keep in mind that this is a managed edition.
There was a problem hiding this comment.
Both kernel and cache are set in the entry point and can therefore be adjusted even in the managed edition.
@contao/developers What's your opinion?
There was a problem hiding this comment.
It's a Contao Managed Edition, you're not supposed to change anything. If you really need to, your kernel must extend ContaoKernel, that's totally fine for me. If you really don't want that, then simply also create your own cache kernel.
|
Thank you @Toflar. |
Description ----------- Automatically invalidates DCA entries when users edit them in the back end. For testing purposes I've added corresponding tags on the page response. Depends on contao/manager-bundle#67 which itself depends on other PR's again. Leaving it here for reference and to be updated. Commits ------- 539bb9f Introduced auto cache tag invalidation on DCAs for better DX c877b8b Merge branch 'master' into auto-dca-cache-tag-invalidation 26fbbb3 Renamed the tags 3804d9d Fix the coding style.
contao#1478). Description ----------- Automatically invalidates DCA entries when users edit them in the back end. For testing purposes I've added corresponding tags on the page response. Depends on contao/manager-bundle#67 which itself depends on other PR's again. Leaving it here for reference and to be updated. Commits ------- 539bb9fe Introduced auto cache tag invalidation on DCAs for better DX c877b8b0 Merge branch 'master' into auto-dca-cache-tag-invalidation 26fbbb3a Renamed the tags 3804d9df Fix the coding style.
While enabling the FOSHttpCacheBundle I noticed that configuration for purging the tags is still a bit cumbersome so I worked on this (FriendsOfSymfony/FOSHttpCache#419) and I am trying to get this into the bundle because it will greatly simplify our integration.
I'll keep this PR up-to-date with the changes on FOSHttpCache(Bundle). Once - hopefully - this gets all released as version 2.3, I'll finish this PR so it can be merged.