Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS Teaser Image as media:content #7

Closed
issue-bot opened this issue Feb 17, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@issue-bot
Copy link
Collaborator

commented Feb 17, 2017

Issue by @pswerbung
February 16th, 2017, 15:29 GMT

Können wir nicht das Teaser Image in zukünftigen Contao Versionen als <media:content> Element statt als <enclosure> einfügen?

Dienste wie MailChimp könnten dann die Bilder aus dem RSS-Feed lesen und ausgeben. Das wäre wohl hier zu implementieren:
https://github.com/contao/core/blob/3.5.24/system/modules/news/classes/News.php#L209-L218

Was spricht dagegen?

@issue-bot issue-bot added the feature label Feb 17, 2017

@issue-bot

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 17, 2017

Comment by @fritzmg
February 16th, 2017, 15:59 GMT

Reference regarding MailChimp: http://kb.mailchimp.com/merge-tags/rss-merge-tags

*|RSSITEM:IMAGE|*

Related RSS tag: media:content

What it displays: In certain feed set-ups, this tag displays the image defined in the media:content tag. Child elements like height, width and source URL aren't editable in MailChimp, but can be included in the RSS feed on your site.

@leofeyer

This comment has been minimized.

Copy link
Member

commented Sep 28, 2017

@contao/developers Any objections?

@Toflar

This comment has been minimized.

Copy link
Member

commented Sep 28, 2017

Nope, as long as this complies with the standard, I'm fine with it. If it's not, it has to be fixed by MailChimp.

@aschempp

This comment has been minimized.

Copy link
Contributor

commented Sep 28, 2017

LGTM

@leofeyer leofeyer self-assigned this Nov 21, 2017

@leofeyer leofeyer added this to the 4.5.0 milestone Nov 21, 2017

leofeyer added a commit to contao/core-bundle that referenced this issue Nov 21, 2017

leofeyer added a commit that referenced this issue Nov 21, 2017

@leofeyer

This comment has been minimized.

Copy link
Member

commented Nov 21, 2017

Implemented in 050e8c3.

@leofeyer leofeyer closed this Nov 21, 2017

leofeyer added a commit to contao/calendar-bundle that referenced this issue Nov 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.