What is authorName and where is it coming from?

[Toflar]

I must be blind...can anybody explain me where this line takes the author name from?

news-bundle/src/Resources/contao/classes/News.php

Line 184 in 46256ca

$objItem->author = $objArticle->authorName;

I cannot find the logic behind this.

[fritzmg]

Looks indeed like a relic from Contao 2. As a matter of fact, no author information is generated in the RSS feeds. Tested on demo.contao.org:

RSS 2.0 entry:

<item>
  <title>Contao is popular</title>
  <description><![CDATA[<p>In a recent security level comparison Contao excelled as one of the most secure Open Source CMS's.</p>]]></description>
  <link>https://demo.contao.org/en/news-detail/contao-is-popular.html</link>
  <pubDate>Mon, 17 Feb 2014 14:27:00 +0100</pubDate>
  <guid>https://demo.contao.org/en/news-detail/contao-is-popular.html</guid>
</item>

Atom entry:

<entry>
  <title>Contao is popular</title>
  <content type="xhtml"><div xmlns="http://www.w3.org/1999/xhtml"><p>In a recent security level comparison Contao excelled as one of the most secure Open Source CMS's.</p></div></content>
  <link rel="alternate" href="https://demo.contao.org/en/news-detail/contao-is-popular.html" />
  <updated>2014-02-17T14:27:00+01:00</updated>
  <id>https://demo.contao.org/en/news-detail/contao-is-popular.html</id>
  <author><name></name></author>
</entry>

With the Atom entry you can see that an <author> node is in fact added to the <entry>, however it is empty.

[leofeyer]

The author name should appear in the Atom feed.

[fritzmg]

It works in neither feed. While the Atom feed does add an <author> entry, it will be empty since authorName is a non-existant variable of the model. It should be ->getRelated('author')->name instead for example (with null check).

[leofeyer]

Fixed in 9f46a7d.