Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review whitelist.txt #54

Closed
Toflar opened this issue Dec 28, 2018 · 8 comments

Comments

Projects
None yet
3 participants
@Toflar
Copy link
Member

commented Dec 28, 2018

Hey everyone,

I've implemented automated spell checking on meta data (at the moment only title and description are spell checked against) so that we can further improve the quality of our meta data.

It is based on GNU Aspell (http://aspell.net).

There's a whitelist.txt file which contains all exceptions to what Aspell thinks is wrong and for the sake of simplicity I've added everything it found during the first run to that whitelist. So basically the whitelist now certainly contains words that are incorrectly spelled.

It would be great if you could help to review that file and if you find something, create a PR where you:

  • remove that word from the whitelist.txt
  • fix the issues in the linter finds.
@Toflar

This comment has been minimized.

Copy link
Member Author

commented Dec 28, 2018

Example: ef3ccad

@MDevster

This comment has been minimized.

Copy link
Collaborator

commented Dec 28, 2018

We should not set the hurdle for new commits so high. I do not believe that all users want to install all dictionaries to run the tests and just want to maintain their own native language. What happens if a mistake appears in a language that is foreign to me? The user will probably just give up.

@Toflar

This comment has been minimized.

Copy link
Member Author

commented Dec 28, 2018

You don‘t have to install anything at all. Just do the changes and create a PR. Travis will then tell you what‘s wrong and you can continue to update your PR to fix the issues.

@MDevster

This comment has been minimized.

Copy link
Collaborator

commented Dec 28, 2018

I think I can only get the first mistake back. That should be very complicated should there be several mistakes.

@Toflar

This comment has been minimized.

Copy link
Member Author

commented Dec 28, 2018

I could optimize this, that‘s not a problem.

@dmolineus

This comment has been minimized.

Copy link
Contributor

commented Jan 2, 2019

I had a short look to the whitelist. To increase the quality to a next level you might think about providing whitelists for each language.

@Toflar

This comment has been minimized.

Copy link
Member Author

commented Jan 3, 2019

That's true, should not be a big deal to do, I'll leave the issue open.

@Toflar

This comment has been minimized.

Copy link
Member Author

commented Jan 9, 2019

Whitelists are now localized, thanks @dmolineus

@Toflar Toflar closed this Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.