Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added all Contao repos #123

Merged
merged 10 commits into from Oct 3, 2019

Conversation

@aschempp
Copy link
Contributor

commented Sep 30, 2019

No description provided.

@aschempp aschempp requested review from ausi, Toflar and leofeyer Sep 30, 2019
Copy link
Member

left a comment

Why do you add translations for non-discoverable packages?

meta/contao/manager-bundle/en.yml Outdated Show resolved Hide resolved
meta/contao/manager-bundle/de.yml Outdated Show resolved Hide resolved
@aschempp

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2019

Why do you add translations for non-discoverable packages?

Contao Manager 1.2 shows information for all packages. Discoverable means they can be searched for, but suggestions etc. are not found in the search but can have a package description.

@aschempp aschempp force-pushed the feature/core-repos branch from 3a3c86f to 9d35d82 Oct 2, 2019
aschempp added 2 commits Oct 2, 2019
@aschempp aschempp requested a review from leofeyer Oct 2, 2019
Copy link
Member

left a comment

As discussed, "Contao Managed Edition" is not a product name, therefore the correct spelling is:

  • English: Contao managed edition
  • German: Contao Managed-Edition
meta/contao/official-demo/en.yml Outdated Show resolved Hide resolved
meta/contao/skeleton-bundle/en.yml Outdated Show resolved Hide resolved
meta/contao/skeleton-bundle/en.yml Outdated Show resolved Hide resolved
meta/contao/skeleton-bundle/en.yml Outdated Show resolved Hide resolved
meta/contao/tcpdf-bundle/en.yml Outdated Show resolved Hide resolved
@leofeyer

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

As discussed with @aschempp in Slack, "Contao Managed Edition" is eventually a product name and thus needs to be written as "Contao Managed Edition" in all languages.

@aschempp aschempp requested a review from leofeyer Oct 3, 2019
@aschempp aschempp requested a review from leofeyer Oct 3, 2019
@aschempp aschempp merged commit d5782ad into master Oct 3, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@aschempp aschempp deleted the feature/core-repos branch Oct 3, 2019
coastforge-cro added a commit to Kuestenschmiede/package-metadata that referenced this pull request Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.