Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels for contao/core #198

Merged
merged 2 commits into from Feb 17, 2020
Merged

Add labels for contao/core #198

merged 2 commits into from Feb 17, 2020

Conversation

@aschempp
Copy link
Contributor

aschempp commented Feb 13, 2020

I often see contao/core as a conflicting package. I thought about adding a label for it. But that really only makes sense if people know what "Contao 4" is. Not sure if you like that change though?

@aschempp aschempp requested review from ausi, Toflar and leofeyer Feb 13, 2020
Copy link
Member

leofeyer left a comment

I'm ok with "Contao 3" but not with "Contao 4", because at some point contao/core-bundle will be "Contao 5" and then we will have a problem.

@aschempp

This comment has been minimized.

Copy link
Contributor Author

aschempp commented Feb 13, 2020

I know, thats why we didn't use / removed the "4" everywhere. But without the number, it's not clear what that package really is. Also, if there really is a v5, it could be 5 years from now, and we can always change the label? 🤷‍♂

@leofeyer

This comment has been minimized.

Copy link
Member

leofeyer commented Feb 13, 2020

To me contao/core is Contao 3 (old) and contao/core-bundle is Contao (current).

@aschempp

This comment has been minimized.

Copy link
Contributor Author

aschempp commented Feb 13, 2020

And you think it's "understandable" (from a user perspective) if one package is "Contao Core" and the other is "Contao 3" ?

@leofeyer

This comment has been minimized.

Copy link
Member

leofeyer commented Feb 13, 2020

Probably not. What about "Contao Legacy" and "Contao Core"?

@Toflar Toflar removed their request for review Feb 14, 2020
@aschempp

This comment has been minimized.

Copy link
Contributor Author

aschempp commented Feb 15, 2020

How would you call "Contao Legacy" in german? Also, wouldn't that be "Legacy Contao" (legacy being a verb)?

@ausi

This comment has been minimized.

Copy link
Member

ausi commented Feb 15, 2020

I’d use “Contao 3 (legacy)” and “Contao 3 (veraltet)” and keep “Contao Core” for contao/core-bundle

@aschempp aschempp force-pushed the bugfix/contao3 branch from 7714714 to ab9562c Feb 17, 2020
@aschempp aschempp requested a review from Toflar as a code owner Feb 17, 2020
@aschempp aschempp force-pushed the bugfix/contao3 branch from ab9562c to 0589f02 Feb 17, 2020
@aschempp aschempp requested review from leofeyer and Toflar Feb 17, 2020
@aschempp aschempp merged commit be94736 into master Feb 17, 2020
1 check passed
1 check passed
lint
Details
@aschempp aschempp deleted the bugfix/contao3 branch Feb 17, 2020
@aschempp

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.