Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the core-bundle functional tests for phpstan runtime #4

Merged
merged 3 commits into from Jun 12, 2019

Conversation

Projects
None yet
3 participants
@aschempp
Copy link
Contributor

commented Jun 11, 2019

Thanks to the functional test in core-bundle, we don't need to duplicate the whole functionality in the phpstan utils.

aschempp added a commit to aschempp/contao that referenced this pull request Jun 11, 2019

@aschempp aschempp referenced this pull request Jun 11, 2019

Merged

Add expiration based persistent rememberme token #483

2 of 2 tasks complete
@@ -93,9 +93,14 @@ public static function getServiceIdFromNode(Expr $node, Scope $scope): ?string
private function createKernel(): void
{
putenv('DB_HOST=');

This comment has been minimized.

Copy link
@leofeyer

leofeyer Jun 11, 2019

Member

Is it necessary to unset these variables or did you just do it because they are not used?

This comment has been minimized.

Copy link
@aschempp

aschempp Jun 11, 2019

Author Contributor

Its actually not unsetting them, its setting them because they are required by the test configuration https://github.com/contao/contao/blob/master/core-bundle/tests/Functional/app/config/config_test.yml#L35-L38

@@ -20,7 +20,8 @@
"symfony/templating": "^4.1"
},
"require-dev": {
"contao/core-bundle": "^4.6",
"contao/core-bundle": "^4.7",
"contao/news-bundle": "^4.7",

This comment has been minimized.

Copy link
@leofeyer

leofeyer Jun 12, 2019

Member

Why do we need the news-bundle?

This comment has been minimized.

Copy link
@aschempp

@leofeyer leofeyer merged commit c54e0a4 into contao:master Jun 12, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
@leofeyer

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

Thank you @aschempp.

leofeyer added a commit to aschempp/contao that referenced this pull request Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.