New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DatabaseTrait #3

Merged
merged 3 commits into from Jan 6, 2019

Conversation

Projects
None yet
2 participants
@aschempp
Copy link
Contributor

aschempp commented Jan 4, 2019

Should be released as v1.6

@@ -10,7 +10,8 @@
}
],
"require": {
"php": "^7.1"
"php": "^7.1",
"ext-pdo": "*"

This comment has been minimized.

@leofeyer

leofeyer Jan 4, 2019

Member

Since the test case does not use the trait, I wonder if adding this is correct. Should it not be added in the composer.json file of the bundle that uses the trait? Because contao/calendar-bundle currently has no functional tests but still requires the test case; and it works perfectly fine without ext-pdo.

This comment has been minimized.

@aschempp

aschempp Jan 6, 2019

Contributor

🤔 valid question, I don't know how this is handled. Maybe it should be suggested only? And it should be a dev requirement?

@leofeyer leofeyer added the enhancement label Jan 6, 2019

@leofeyer leofeyer merged commit b78689c into contao:master Jan 6, 2019

@leofeyer

This comment has been minimized.

Copy link
Member

leofeyer commented Jan 6, 2019

Thank you @aschempp.

leofeyer added a commit that referenced this pull request Jan 7, 2019

Add a database trait (see #3)
Description
-----------

Should be released as v1.6

Commits
-------

c8130ac Added DatabaseTrait
8ec4825 Change ext-pdo to be optional
b27c362 Throw an exception if the SQL file does not exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment