fix: do not convert path to utf8 in open_file_binary#160
Closed
fwanderse wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Other suggestion: remove the C FFI function that is misbehaving to inline correct behavior in the functions that need it. |
Collaborator
|
#160 is merged instead |
fwanderse
deleted the
fw-anderse/fix-utf8-convert-issue-in-open_file_binary
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builder::add_ingredient may fail with non-ascii characters in source_path
Issue: #156