Skip to content

fix: do not convert path to utf8 in open_file_binary #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fwanderse wants to merge 1 commit into from
Closed

fix: do not convert path to utf8 in open_file_binary #160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/c2pa.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,13 +240,12 @@ inline std::string path_to_string(const std::filesystem::path &source_path)
template<typename StreamType>
inline std::unique_ptr<StreamType> open_file_binary(const std::filesystem::path &path)
{
auto path_str = path_to_string(path);
auto stream = std::make_unique<StreamType>(
path_str,
path,
std::ios_base::binary
);
if (!stream->is_open()) {
throw C2paException("Failed to open file: " + path_str);
throw C2paException("Failed to open file: " + path.string());
}
return stream;
}
Expand Down