Delivery and Management API specific options - #135
Merged
David Litvak Bruno (dlitvakb) merged 10 commits intoOct 11, 2019
Merged
Delivery and Management API specific options#135David Litvak Bruno (dlitvakb) merged 10 commits into
David Litvak Bruno (dlitvakb) merged 10 commits into
Conversation
This is to allow to pass different configuration values of the same option to Delivery and Management clients.
It's needed if we want to say configure the Delivery API to fail quickly as we don't want to hog page rendering, and on the other hand let Management API take as long as needed in the same app, as those queries are not run by visitors and don't have to be fast.
```
config.options = {
# Optional:
# Use `delivery_api` and `management_api` keys to limit to what API the settings
# will apply. Useful because Delivery API is usually visitor facing, while Management
# is used in background tasks that can run much longer. For example:
delivery_api: {
timeout_read: 6
},
management_api: {
timeout_read: 100
}
}
```
This reverts commit 7ebfa49.
Contributor
Author
|
The CI is finally green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to allow to pass different configuration values of the same option to Delivery and Management clients.
It's needed if we want to say configure the Delivery API to fail quickly as we don't want to hog page rendering, and on the other hand let Management API take as long as needed in the same app, as those queries are not run by visitors and don't have to be fast.
Also in this PR
webmockwas updated to latest version, because the previous version was causing VCR fails when running test suite locally or on Travis. This bug: https://www.bountysource.com/issues/54892151-twitter-gem-vcr-request-initialized-with-an-invalid-body