Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃挕 Proposal - Remove underline in links #627

Closed
Gracegross opened this issue Nov 5, 2020 · 9 comments 路 Fixed by #637
Closed

馃挕 Proposal - Remove underline in links #627

Gracegross opened this issue Nov 5, 2020 · 9 comments 路 Fixed by #637

Comments

@Gracegross
Copy link

Forma 36 contribution proposal

The underline on all links makes the page less readable and is unnecessary. It is also such an out-dated way to visual a link, it makes Contentful look naff. Down with underlines!!!

Let's get rid of the underline and simply indicate link by making the text blue.

Breaking changes

@gui-santos
Copy link
Contributor

I'm down for it!

How should the hover state be? Underline or just a different blue?

@Gracegross
Copy link
Author

I'm down for it!

How should the hover state be? Underline or just a different blue?

Yes!!! fabulous idea

@domarku
Copy link
Contributor

domarku commented Nov 5, 2020

Thanks for the proposal, @Gracegross!

Making the links just another color might not be enough to separate them from the rest of the text. We could also make the links thicker (like a semibold or a bold) and do what @gui-santos suggested on hover.

@denkristoffer
Copy link
Collaborator

As long as there's some sort of way to differentiate links from body text for colour blind people. I'm sure we can come up with something good 馃檪

@Gracegross
Copy link
Author

Gracegross commented Nov 6, 2020

Here are the accessiblity guidelines I found:

  • A non-color indicator, such as an underline, must be present on hover
  • The contrast ratio between the surrounding text and the background must be at least 4.5:1
  • The contrast ratio between the link and the background must be at least 4.5:1
  • The contrast ratio between the link and the surrounding text must be at least 3:1.

I propose these changes:

  • underline on hover
  • change colour from 3965AD to 2E75D4 ...this is a higher contrast
  • thoughts on making it semi-bold? I'm not too opinionated

Here is the current version and 2 new versions... one semibold, one regular
Screenshot 2020-11-06 at 14 11 17

Screenshot 2020-11-06 at 14 10 28

Screenshot 2020-11-06 at 14 10 16

@m10l
Copy link
Contributor

m10l commented Nov 6, 2020

Nice! Like the changes 馃殌

@domarku
Copy link
Contributor

domarku commented Nov 6, 2020

Cool, me too! Vote for semibold 馃憤

@m10l
Copy link
Contributor

m10l commented Nov 6, 2020

I'd vote against semibold as it'd have a negative impact on our Rich Text editor. Could be a prop though

@domarku
Copy link
Contributor

domarku commented Nov 6, 2020

Wait, what's the negative impact? Inline links? Seems like it wouldn't be a big change (or am I looking at the wrong thing)

Nov-06-2020 18-11-35

@gui-santos gui-santos linked a pull request Nov 13, 2020 that will close this issue
8 tasks
@gui-santos gui-santos removed needs review Proposal/bug that needs to be reviewed by maintainers needs triage labels Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment