Feature/prefix #42
Merged
Feature/prefix #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…modifications to git stage.
himanshu-contentstack
suggested changes
Feb 19, 2024
| } | ||
|
|
||
| if (err) | ||
| return { |
Contributor
There was a problem hiding this comment.
you do not need to return from try block, throw is suffice
Contributor
Author
There was a problem hiding this comment.
No, Actually we don't need to throw it. Because:
- It's a proxy request from contentstack to user.
- In our error middleware we cannot throw an error with an object, we're throwing message with status.
| fileName | ||
| ); | ||
|
|
||
| return { |
Contributor
There was a problem hiding this comment.
return not needed from try
Contributor
Author
There was a problem hiding this comment.
No, Actually we don't need to throw it. Because:
- It's a proxy request from contentstack to user.
- In our error middleware we cannot throw an error with an object, we're throwing message with status
himanshu-contentstack
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.