-
Notifications
You must be signed in to change notification settings - Fork 8
fix:master-locale not showing for new stack and title and url bugs in… #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| const [csOptions, setcsOptions] = useState(options); | ||
| const [sourceoptions, setsourceoptions] = useState(sourceOptions); | ||
| const newMigrationData = useSelector((state: RootState) => state?.migration?.newMigrationData); | ||
| const [selectedStack,setselectedStack] = useState<IDropDown>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use proper format like [selectedStack, setSelectedStack]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| const [sourceLocales, setsourceLocales] = useState<{ label: string; value: string }[]>([]); | ||
| const [isLoading, setisLoading] = useState<boolean>(false); | ||
| const [localeChanged, setlocaleChanged] = useState<boolean>(false); | ||
| const [currentStack, setcurrentStack] = useState<IDropDown>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be setCurrentStack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| setpreviousStack(prevStackRef?.current); | ||
| } | ||
| prevStackRef.current = stack; | ||
| }, [stack]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow same proper format in useState above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
fix:master-locale not showing for new stack and title and url bugs in…
fix:master-locale not showing for new stack and title and url bugs in…
… content-mapper