Skip to content

Conversation

@AishDani
Copy link
Contributor

@AishDani AishDani commented May 6, 2025

No description provided.

@AishDani AishDani requested a review from a team as a code owner May 6, 2025 08:06
@AishDani AishDani requested review from RohitKini and sayalijoshi27 and removed request for a team May 6, 2025 08:06
@sauravraw sauravraw requested a review from Copilot May 6, 2025 08:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds login functionality for organization owners by updating both user and authentication services to include owner organizations, and it refines the UI component code for displaying CMS information.

  • Updated Card component to use nullish coalescing for cleaner CMS value handling.
  • Modified user and auth services to merge owner organizations with admin organizations for login functionality.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
ui/src/components/Card/index.tsx Changed ternary operator to nullish coalescing for CMS display.
api/src/services/user.service.ts Added filtering and merging for owner organizations.
api/src/services/auth.service.ts Updated org filtering and error handling logic for login.
Comments suppressed due to low confidence (3)

api/src/services/auth.service.ts:77

  • [nitpick] Review the consistency of using optional chaining for filtering organization roles, and adjust formatting if needed for better readability.
if (!orgs?.length && !ownerOrgs?.length) {

ui/src/components/Card/index.tsx:82

  • The change to use the nullish coalescing operator improves clarity; please confirm that falsey values other than null or undefined are intended to be handled differently.
{project?.legacy_cms?.cms ?? '-'}

api/src/services/user.service.ts:75

  • Ensure merging orgs and ownerOrgs does not lead to duplicate organization entries if an organization qualifies for both categories; consider de-duplicating if necessary.
const allOrgs = [...orgs, ...ownerOrgs]

@sayalijoshi27 sayalijoshi27 merged commit 086d2aa into dev May 6, 2025
3 of 4 checks passed
umeshmore45 pushed a commit that referenced this pull request Jun 11, 2025
fix:added login functionality for org owner
AishDani pushed a commit that referenced this pull request Jul 26, 2025
fix:added login functionality for org owner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants