**Fix:** Remove sidenav border in dark mode. #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImogenF
force-pushed
the
PLAT-811-fix-sidenav-border
branch
from
6f4ee66
to
28bd454
Compare
TejasQ
suggested changes
Aug 12, 2019
src/Sidenav/Sidenav.tsx
Outdated
| borderRight: "1px solid", | ||
| borderRightColor: theme.color.separators.default, | ||
| ...(dark | ||
| ? {} |
There was a problem hiding this comment.
I think a logical and operator makes more sense than a one-sided ternary in this case. 🤔
|
Is this correct? |
TejasQ
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://contiamo.atlassian.net/browse/PLAT-811
Grey border on the right of the sidebar is now only there if the sidenav has a white background - in dark mode, it is gone.
Related issue
To be tested
Me
localhost:6060Tester 1
Tester 2