Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

useGet hooks #103

Merged
merged 24 commits into from Mar 25, 2019

Conversation

Projects
None yet
4 participants
@fabien0102
Copy link
Contributor

commented Mar 11, 2019

Why

Begin the migration to hooks to enable super powers 馃挴

This PR introduce all the feature of Get but in hook implementation under useGet.

@fabien0102 fabien0102 requested a review from TejasQ Mar 11, 2019

@fabien0102 fabien0102 self-assigned this Mar 11, 2019

@contiamo-ci

This comment has been minimized.

Copy link

commented Mar 11, 2019

Warnings
鈿狅笍

鉂楋笍 Big PR

Generated by 馃毇 dangerJS

Show resolved Hide resolved src/Context.tsx Outdated
Show resolved Hide resolved src/useGet.tsx Outdated
Show resolved Hide resolved src/useGet.tsx Outdated
@TejasQ
Copy link
Collaborator

left a comment

Looks amazing. 馃帀

I'd request some small changes though.

Show resolved Hide resolved src/useGet.tsx
Show resolved Hide resolved src/useGet.tsx Outdated
Show resolved Hide resolved src/useGet.tsx Outdated
Show resolved Hide resolved src/useGet.tsx Outdated
Show resolved Hide resolved src/useGet.tsx Outdated
Show resolved Hide resolved src/useGet.tsx Outdated

fabien0102 added some commits Oct 26, 2018

Add a lot of unit tests to useGet
- Implement debounce
- Fix update policies
- Fix network error handling

fabien0102 added some commits Mar 24, 2019

@TejasQ
Copy link
Collaborator

left a comment

Let's merge it before it becomes frankenstein.

BUT there's some stuff to change in this PR.

Show resolved Hide resolved src/useGet.tsx Outdated

@fabien0102 fabien0102 requested a review from TejasQ Mar 25, 2019

@TejasQ

TejasQ approved these changes Mar 25, 2019

@fabien0102 fabien0102 merged commit ff6ee0d into master Mar 25, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@fabien0102 fabien0102 deleted the hooks branch Mar 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.