Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support requestBody fields that are reference objects #208

Merged
merged 1 commit into from Jan 11, 2020

Conversation

@seanlaff
Copy link
Contributor

seanlaff commented Jan 11, 2020

Fixes #177

As per the OpenApi spec, requestBody inside the Operation object may be a reference. Previously restful-react was not generating types for this case.

I added a new endpoint to the extended petstore yaml that exhibits this behavior for testing.

@TejasQ TejasQ requested a review from fabien0102 Jan 11, 2020
@TejasQ
TejasQ approved these changes Jan 11, 2020
Copy link
Collaborator

TejasQ left a comment

Looks really good to me! Great work! Will let @fabien0102 press the button. 🔜

Copy link
Contributor

fabien0102 left a comment

Amazing! Thanks a lot! 😍

@fabien0102 fabien0102 merged commit 3ff62a8 into contiamo:master Jan 11, 2020
7 checks passed
7 checks passed
Header rules - restful-react No header rules processed
Details
Pages changed - restful-react 3 new files uploaded
Details
Redirect rules - restful-react No redirect rules processed
Details
Mixed content - restful-react No mixed content detected
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/restful-react/deploy-preview Deploy preview ready!
Details
@fabien0102

This comment has been minimized.

Copy link
Contributor

fabien0102 commented Jan 11, 2020

I will publish a new npm version on monday, I'm not on my computer 😉

@seanlaff

This comment has been minimized.

Copy link
Contributor Author

seanlaff commented Jan 11, 2020

Thanks guys, this is a great library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.