Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Tsdx #215

Merged
merged 6 commits into from Jan 14, 2020
Merged

Migrate to Tsdx #215

merged 6 commits into from Jan 14, 2020

Conversation

@fabien0102
Copy link
Contributor

fabien0102 commented Jan 13, 2020

Why

Our project is not compiled to umd, and I saw this package mentionned somewhere in our issues ^^ (and as a curious person, I had to give a try 馃榿)

@weyert I would like to have your feedback on this one, since you tried the "manual" version in #212

Notes

  • I had to fix all the tests types since I increase the typesafety.
  • I still have a custom rollup for the scripts due to jaredpalmer/tsdx#338
@fabien0102 fabien0102 requested a review from mpotomin Jan 13, 2020
@fabien0102 fabien0102 self-assigned this Jan 13, 2020
@contiamo-ci

This comment has been minimized.

Copy link

contiamo-ci commented Jan 13, 2020

Warnings
鈿狅笍 鉂楋笍 Big PR

Generated by 馃毇 dangerJS against 1e2e40f

@weyert

This comment has been minimized.

Copy link

weyert commented Jan 13, 2020

Hah, looks easier than my version. Let's go for this. I will see if I can publish the package with Verdaccio locally and then test if it works as expected in CRA

@fabien0102

This comment has been minimized.

Copy link
Contributor Author

fabien0102 commented Jan 14, 2020

@weyert You can try with restful-react@9.7.1-3-gc0047cb (publish as canary version) 馃槈

.eslintrc.js Outdated Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
fabien0102 added 4 commits Jan 13, 2020
@fabien0102

This comment has been minimized.

Copy link
Contributor Author

fabien0102 commented Jan 14, 2020

New version here to test in real condition -> restful-react@9.7.1-6-g0969004

@fabien0102

This comment has been minimized.

Copy link
Contributor Author

fabien0102 commented Jan 14, 2020

image

Still need some work鈥

Edit: Fixed! Also remove the usage of lodash/fp because not compatible with tsdx optimizations

fabien0102 added 2 commits Jan 14, 2020
鈥 (used by tsdx)
@fabien0102 fabien0102 requested a review from TejasQ Jan 14, 2020
@fabien0102

This comment has been minimized.

Copy link
Contributor Author

fabien0102 commented Jan 14, 2020

Tested againts a fresh new CRA locally, everything follow!

@fabien0102 fabien0102 merged commit 7aa3d75 into master Jan 14, 2020
9 checks passed
9 checks passed
Header rules - restful-react No header rules processed
Details
Pages changed - restful-react 3 new files uploaded
Details
Redirect rules - restful-react No redirect rules processed
Details
Mixed content - restful-react No mixed content detected
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
netlify/restful-react/deploy-preview Deploy preview ready!
Details
@fabien0102 fabien0102 deleted the tsdx branch Jan 14, 2020
@weyert

This comment has been minimized.

Copy link

weyert commented Jan 14, 2020

Sweet, same here! 馃拑
Excited to update to this new version!!! Will you publish a new version?

@seanlaff

This comment has been minimized.

Copy link
Contributor

seanlaff commented Jan 14, 2020

Thanks for taking the time to do this- makes it much easier to consume :)

@South-Paw

This comment has been minimized.

Copy link
Contributor

South-Paw commented Jan 14, 2020

Great job @fabien0102 馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can鈥檛 perform that action at this time.