Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSCH may lock up the Simplelink-cc13xx-cc26xx platform when setting channel #977

Closed
hseokman opened this issue May 28, 2019 · 4 comments

Comments

@hseokman
Copy link

commented May 28, 2019

While I was looking into implementing TSCH on Simplelink platform, I found an issue.

set_value with RADIO_PARAM_CHANNEL calls set_channel function which calls netstack_sched_fs.
netstack_sched_fs uses RF_runCmd which is synchronous function that should not be called from the interrupt handler. tsch_slot_operation uses rtimer which calls the function from the interrupt handler. When tsch_slot_operation calls to change channel, the device locks up.

Looking at cc26x0-cc13x0 implementation, set_channel function does not send any radio command. The channel was set when the radio is turned on.

@hseokman hseokman changed the title TSCH locks up on setting channel on Simplelink-cc13xx-cc26xx platform TSCH may lock up the Simplelink-cc13xx-cc26xx platform when setting channel May 28, 2019

@hseokman

This comment has been minimized.

Copy link
Author

commented May 29, 2019

Since the function name is netstack_sched_fs, shouldn't it schedule the command? Shouldn't it call RF_scheduleCmd instead of RF_runCmd?

@hseokman

This comment has been minimized.

Copy link
Author

commented May 29, 2019

The same issue is present in netstack_sched_ieee_tx and netstack_sched_prop_tx. They schedule to transmit a packet and wait for completion with RF_pendCmd which will block from the interrupt handler of rtimer.

@zhuqiyun

This comment has been minimized.

Copy link

commented Jul 19, 2019

focus

@g-oikonomou

This comment has been minimized.

Copy link
Member

commented Aug 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.