Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Implemented Snmp v1 and v2c #1020
This is a lightweight implementation of SNMP.
Currently, I'm still working on unit tests and documentation. But the core code is already in place and working.
It would be interesting to know from the community which data types are more relevant. There are several data types on the ASN1.1 that can be used in the SNMP protocol. But I do not see a point in implementing all of them and increasing the code footprint.
I would also like to know if the best approach is to provide by default some MIB implementations, like the IF-MIB or the SYSTEM-MIB.
I'm currently working on a MIB for the Contiki. I already got a Private Enterprise Number from IANA. The Contiki-ng number is 54352. The complete list is here: https://www.iana.org/assignments/enterprise-numbers/enterprise-numbers
Cool stuff! Some things I would like and that I saw in the diffs:
g-oikonomou left a comment
This is really cool, very professional-looking contribution and good job on the doxygen.
You will need to include a travis compile test for the platforms you have tested at least. What platforms did you actually test this on?
Some other changes requested, nothing major.
The naming convention is non-standard in
As we discussed on gitter, I'd rather go without SET functionality (at least for now). Perhaps one day over DTLS ;)
I guess the key remaining question is: How do we know this is SNMP-compliant? :) Is there an easy way to test it? It would be really cool to have a test similar to what we have with the native MQTT-client. That is a test where we use some existing tool to send commands to the server and check for the correctness of the replies.
Again, thanks for this!
Thank you for the review.
First of all, my history was messy and after implementing the changes you requested I rebased the branch, it should be easier to see the changes as well.
The answer for your questions:
1 - I tested this on the native, cooja and I'll test it in the cc26x0-cc13x0, which is the only physical platform I have.
2 - There is a easy way to test if it is SNMP-compliant. I'll implement the Test and commit it here. I know that it is SNMP compliant now, but I do see the point to have a regression test.