Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Release v4.4 #1081
The old code seems to have assumed that the type of UIP_ICMP_BUF was char* (or equivalent) while in fact it was struct uip_icmp_hdr*. Thus when computing the address to UIP_ICMP_BUF[sizeof(struct uip_icmp_hdr)], where sizeof(struct uip_icmp_hdr) = 4, it would increment the pointer by 4*4 = 16 bytes, and not 4 bytes as would be expected.
`rtimer_arch_schedule/1` would cast clock_second as `unsigned short` instead of `unsigned int` causing scheduling to set wrong interval. Example: ```c rtimer_set(&timer, RTIMER_NOW() + CLOCK_SECOND, 0, callback, null); /* with the original code the following would be ouputted from `rtimer-arch.c`: * > rtimer_arch_schedule time 46487236 46466024 in 46466.24000 seconds * * With fix the following, corrected version: * > rtimer_arch_schedule time 46463604 1000 in 1.0 seconds */
This new constant is mandatorily supported by all radio driver get_value() functions. It represents the maximum payload the radio driver is able to handle. This includes the MAC header and MAC payload, but not any tail bytes added automatically by the radio. For example, in the typical case of .15.4 operation at 2.4GHz, this will be 125 bytes (127 bytes minus the FCS / CRC16). This is the maximum number of bytes that: * The MAC layer will ask the radio driver to transmit. This corresponds to the payload_len argument of the prepare() and send() and the transmit_len argument of transmit(). * The radio driver will deliver to the MAC layer after frame reception. The buf_len of the read function will be at greater than or equal to this value. The read() function may not return a value greater than this constant.
Xenial doesn't have ant. This causes failures in tests needs BUILD_COOJA. See - https://blog.travis-ci.com/2019-04-15-xenial-default-build-environment - https://docs.travis-ci.com/user/languages/java/#using-ant-on-ubuntu-xenial-1604
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.