New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sicslowpan vulnerability fixes #972
sicslowpan vulnerability fixes #972
Conversation
|
This seems reasonable to me. Would like to hear what @nfi @joakimeriksson think |
|
I am hoping to take a pass at that tomorrow and hopefully merge! |
…oo large frag_offset is received
efc7752
to
f737794
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on what I can see this looks very good. I also see that we do have a few fragmentation tests in the regression tests so it should be safe to merge!
This PR fixes a number of problems with packet processing in the sicslowpan implementation. PR #900 should pass with the help of these changes.
For future work, it could be good to redesign the sicslowpan module, as it has become a bit convoluted.
Thanks to Tobias Scharnowski for reporting the issues with the add_fragment and store_fragment functions, and the possible use of previous packet data when reassembling a packet.