Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly handling negotiated options of telnet servers #2686

Open
jerrytesting opened this issue Aug 8, 2021 · 1 comment
Open

Incorrectly handling negotiated options of telnet servers #2686

jerrytesting opened this issue Aug 8, 2021 · 1 comment

Comments

@jerrytesting
Copy link

Hello,

In the implementation of telnet servers until version 3.0 and even the latest commit 32b5b17, telnet servers incorrectly handle negotiated options.

According to the general constraints of RFC854, during negotiating some disabled command options or unnegotiated commands, telnet servers must give WILL/WONT or DO/DONT response for DO and WILL commands, respectively.

However, telnet servers may not give any responses in this case. This bug appears as telnet servers put all responses in a fixed-length buffer in the implementation. Telnet servers only put messages into buffer but don't have a check whether successfully or not. Hence, when the buffer is full, it can lead to responses lost. This bug could lead to clients waiting forever and other effects.

Could you have a check? Thanks a lot.

@OS-WS
Copy link

OS-WS commented Sep 6, 2021

Hi,
Is there any plan to fix this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants