Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
cc2538: Add PKA drivers, ECC algorithms and examples #1078
referenced this pull request
Jun 2, 2015
Please squash your commits.
There are a few things that do not comply to https://github.com/contiki-os/contiki/wiki/Code-Contributions and https://github.com/contiki-os/contiki/blob/master/doc/code-style.c, e.g. the function names, the layout of function definitions like
There are a lot of useless double parentheses with
For the function pointer parameters, always qualify the pointed type as
Always restrict the scope of symbols as much as possible. E.g.,
It should be
In the doxygen comments:
The architecture is good. There are many calls to
@alignan: Can you test this after the rework (I do not have hardware)?
Maybe OK for the API/
In your latest push, you have squashed your commits as requested, but you have ignored all the other comments (not only the API/
@drandreas That's much better! There are still a few things to fix:
Thank you for your remarks. I didn't squash the commits to make it easier for you. I will do it at the end.
I found five more
No, it's the macro definitions that have to be made safe by parenthesizing the used parameters, not the macro invocations. Here, the first such occurrence is
4ff1e83 is fine for me, so you can now squash your commits.