cc2531 USB dongle support #18

g-oikonomou · 2012-11-01T15:48:50Z

This patch set adds native USB support for the TI cc2531 USB dongle. This is an important enhancement (read as: we want this upstream pronto)

First things first, credit where credit's due. This work is based on the USB framework in cpu/arm/common/usb. Thanks to Philippe Rétornaz @ EPFL for making the necessary adjustments to the arm usb framework and for writing the low level usb driver for the dongle (among his other very significant contributions).

The result of using this framework is that we've inherited a couple of issues:

Licensing: Many files don't have a license header. Do they have a maintainer currently? Does anyone have direct contact with the original contributor (Simon Berg?)?
The code style leaves a lot to be desired. I've made plenty of fixes but more are still needed (e.g. some variables not in all lowercase). Because i) this is important and ii) I've got a bigger patch lined up with code style cleanup for all 8051-based platforms, I've decided to open this with the code in its current state. Hope that's OK with everyone else.

Change to have a real usb VID/PID and better fit the capabilities of the CC2531 hardware (enpoint size, location). Compile only if the cdc-acm class is requested.

The P2 Interrupt is shared across many periferal (I2C, USB, GPIO). This adds a generic interrupt handler on which the differents drivers can register a handler.

This is mainly a naming convention thing, we want to have 'isr' as part of the name, instead of 'int'. We also want port_2 instead of p2 because we already had port_1

We keep the ISR in its own file and move everything else to a different one, so that we only have to keep the ISR in HOME

- usb cdc-acm: * implement get line coding * use printf only when debugging * Add events - usb-core: do not force debugging

- Fixed DMA irq flag clearing - Added a dma_reset helper

This is based on a usb-test example by Philippe Retornaz. It has been moved to platform and modified accordingly. With this in place: - putchar() can work over USB. So we can use things like printf, slip output - USB input can be redirected to slip or serial input The example itself is no longer needed in the source tree

adamdunkels · 2012-11-01T16:06:31Z

I haven't heard from Simon in a few years I think.

Regarding code style: since this is deep in a platform/ dir, and because you've got a fix upcoming anyway, I say go for it: +1

See Pull Request #18

Change to have a real usb VID/PID and better fit the capabilities of the CC2531 hardware (enpoint size, location). Compile only if the cdc-acm class is requested. See Pull Request #18

The P2 Interrupt is shared across many periferal (I2C, USB, GPIO). This adds a generic interrupt handler on which the differents drivers can register a handler. See Pull Request #18

See Pull Request #18

This is mainly a naming convention thing, we want to have 'isr' as part of the name, instead of 'int'. We also want port_2 instead of p2 because we already had port_1 See Pull Request #18

We keep the ISR in its own file and move everything else to a different one, so that we only have to keep the ISR in HOME See Pull Request #18

See Pull Request #18

- usb cdc-acm: * implement get line coding * use printf only when debugging * Add events - usb-core: do not force debugging See Pull Request #18

See Pull Request #18

- Fixed DMA irq flag clearing - Added a dma_reset helper See Pull Request #18

This is based on a usb-test example by Philippe Retornaz. It has been moved to platform and modified accordingly. With this in place: - putchar() can work over USB. So we can use things like printf, slip output - USB input can be redirected to slip or serial input The example itself is no longer needed in the source tree See Pull Request #18

See Pull Request #18

See Pull Request contiki-os#18

Change to have a real usb VID/PID and better fit the capabilities of the CC2531 hardware (enpoint size, location). Compile only if the cdc-acm class is requested. See Pull Request contiki-os#18

The P2 Interrupt is shared across many periferal (I2C, USB, GPIO). This adds a generic interrupt handler on which the differents drivers can register a handler. See Pull Request contiki-os#18

See Pull Request contiki-os#18

This is mainly a naming convention thing, we want to have 'isr' as part of the name, instead of 'int'. We also want port_2 instead of p2 because we already had port_1 See Pull Request contiki-os#18

We keep the ISR in its own file and move everything else to a different one, so that we only have to keep the ISR in HOME See Pull Request contiki-os#18

See Pull Request contiki-os#18

- usb cdc-acm: * implement get line coding * use printf only when debugging * Add events - usb-core: do not force debugging See Pull Request contiki-os#18

See Pull Request contiki-os#18

- Fixed DMA irq flag clearing - Added a dma_reset helper See Pull Request contiki-os#18

This is based on a usb-test example by Philippe Retornaz. It has been moved to platform and modified accordingly. With this in place: - putchar() can work over USB. So we can use things like printf, slip output - USB input can be redirected to slip or serial input The example itself is no longer needed in the source tree See Pull Request contiki-os#18

See Pull Request contiki-os#18

Closes contiki-os#18

Featurecast

[inga] apps/settings_set: make sure, the settings_set app uses the defin...

platform/mikro-e/dev: add motion click driver and update relay click driver

Philippe Rétornaz and others added 16 commits November 1, 2012 00:22

cc2531: Copy arm usb framework

8b31f84

cc2531: change cdc-acm descriptor

d2f69c6

Change to have a real usb VID/PID and better fit the capabilities of the CC2531 hardware (enpoint size, location). Compile only if the cdc-acm class is requested.

cc253x: Add p2 interrupt handler

f710b25

The P2 Interrupt is shared across many periferal (I2C, USB, GPIO). This adds a generic interrupt handler on which the differents drivers can register a handler.

cc2531: Add USB driver

22171c9

cc253x: Add USB support to the compilation scripts

6879aa5

cc253x: Configurable linkage for the P2 ISR

f8bbf6b

cc253x: Renamed the P2 ISR

d795e4c

This is mainly a naming convention thing, we want to have 'isr' as part of the name, instead of 'int'. We also want port_2 instead of p2 because we already had port_1

cc253x: P2-related routines are now bankable

31c402c

We keep the ISR in its own file and move everything else to a different one, so that we only have to keep the ISR in HOME

cc253x: Renamed P2 interrupt-related files for better consistency

5554f24

cc2531: USB changes:

9d90f7b

- usb cdc-acm: * implement get line coding * use printf only when debugging * Add events - usb-core: do not force debugging

cc253x: optionally push bits in p2 interrupt

da8f26d

cc253x: DMA Changes

9bc7ad8

- Fixed DMA irq flag clearing - Added a dma_reset helper

cc253x: Config to swap between UART and USB I/O

496115d

cc2531: Added a new USB demo project (CDC-ACM)

e42d414

cc2531: USB CDC-ACM code style fixes

a2c64f8

g-oikonomou pushed a commit that referenced this pull request Nov 1, 2012

cc2531: Copy arm usb framework

0e55eb0

See Pull Request #18

g-oikonomou pushed a commit that referenced this pull request Nov 1, 2012

cc2531: Add USB driver

d93fee6

See Pull Request #18

g-oikonomou pushed a commit that referenced this pull request Nov 1, 2012

cc253x: Add USB support to the compilation scripts

ba96408

See Pull Request #18

g-oikonomou added a commit that referenced this pull request Nov 1, 2012

cc253x: Configurable linkage for the P2 ISR

fea4970

See Pull Request #18

g-oikonomou added a commit that referenced this pull request Nov 1, 2012

cc253x: P2-related routines are now bankable

c60f0b4

We keep the ISR in its own file and move everything else to a different one, so that we only have to keep the ISR in HOME See Pull Request #18

g-oikonomou added a commit that referenced this pull request Nov 1, 2012

cc253x: Renamed P2 interrupt-related files for better consistency

c1d7247

See Pull Request #18

g-oikonomou pushed a commit that referenced this pull request Nov 1, 2012

cc2531: USB changes:

0a6e65a

- usb cdc-acm: * implement get line coding * use printf only when debugging * Add events - usb-core: do not force debugging See Pull Request #18

g-oikonomou pushed a commit that referenced this pull request Nov 1, 2012

cc253x: optionally push bits in p2 interrupt

898bd07

See Pull Request #18

g-oikonomou pushed a commit that referenced this pull request Nov 1, 2012

cc253x: DMA Changes

eabaa0c

- Fixed DMA irq flag clearing - Added a dma_reset helper See Pull Request #18

g-oikonomou added a commit that referenced this pull request Nov 1, 2012

cc253x: Config to swap between UART and USB I/O

1a0f01c

See Pull Request #18

g-oikonomou added a commit that referenced this pull request Nov 1, 2012

cc2531: Added a new USB demo project (CDC-ACM)

be93f1a

See Pull Request #18

g-oikonomou closed this in 79cffa0 Nov 1, 2012

EarthLord pushed a commit to EarthLord/contiki that referenced this pull request Jun 18, 2014

cc2531: Copy arm usb framework

d03a646

See Pull Request contiki-os#18

EarthLord pushed a commit to EarthLord/contiki that referenced this pull request Jun 18, 2014

cc2531: Add USB driver

98082e7

See Pull Request contiki-os#18

EarthLord pushed a commit to EarthLord/contiki that referenced this pull request Jun 18, 2014

cc253x: Add USB support to the compilation scripts

bfc6487

See Pull Request contiki-os#18

EarthLord pushed a commit to EarthLord/contiki that referenced this pull request Jun 18, 2014

cc253x: Configurable linkage for the P2 ISR

6ddbad8

See Pull Request contiki-os#18

EarthLord pushed a commit to EarthLord/contiki that referenced this pull request Jun 18, 2014

cc253x: Renamed P2 interrupt-related files for better consistency

6ce7613

See Pull Request contiki-os#18

EarthLord pushed a commit to EarthLord/contiki that referenced this pull request Jun 18, 2014

cc2531: USB changes:

a43c143

- usb cdc-acm: * implement get line coding * use printf only when debugging * Add events - usb-core: do not force debugging See Pull Request contiki-os#18

EarthLord pushed a commit to EarthLord/contiki that referenced this pull request Jun 18, 2014

cc253x: optionally push bits in p2 interrupt

807606d

See Pull Request contiki-os#18

EarthLord pushed a commit to EarthLord/contiki that referenced this pull request Jun 18, 2014

cc253x: DMA Changes

50d9c82

- Fixed DMA irq flag clearing - Added a dma_reset helper See Pull Request contiki-os#18

EarthLord pushed a commit to EarthLord/contiki that referenced this pull request Jun 18, 2014

cc253x: Config to swap between UART and USB I/O

0526811

See Pull Request contiki-os#18

EarthLord pushed a commit to EarthLord/contiki that referenced this pull request Jun 18, 2014

cc2531: Added a new USB demo project (CDC-ACM)

f8466c2

See Pull Request contiki-os#18

EarthLord pushed a commit to EarthLord/contiki that referenced this pull request Jun 18, 2014

cc2531: USB CDC-ACM code style fixes

d3539ac

Closes contiki-os#18

simonduq referenced this pull request in simonduq/contiki Jul 2, 2014

Merge pull request #18 from harnen/calipso-integrated

16968a2

Featurecast

ejoerns pushed a commit to ejoerns/contiki-inga that referenced this pull request Oct 11, 2014

Merge pull request contiki-os#18 from comawill/settings

7fe704c

[inga] apps/settings_set: make sure, the settings_set app uses the defin...

mtusnio referenced this pull request in CreatorDev/contiki Oct 21, 2016

Merge pull request #18 from mayank-sirotiya-imgtec/add_drivers

bb4e4ba

platform/mikro-e/dev: add motion click driver and update relay click driver

This was referenced Jul 9, 2018

Stack based buffer overflow while parsing AQL (name of relation) #2486

Open

Global buffer overflow while parsing AQL (lvm_set_op, lvm_set_relation, lvm_set_operand) #2487

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cc2531 USB dongle support #18

cc2531 USB dongle support #18

g-oikonomou commented Nov 1, 2012

adamdunkels commented Nov 1, 2012

cc2531 USB dongle support #18

cc2531 USB dongle support #18

Conversation

g-oikonomou commented Nov 1, 2012

adamdunkels commented Nov 1, 2012