Skip to content

Conversation

@uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Nov 28, 2025

Description

Re-opens #8328

resolves CON-4878

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Switch to clearer env vars to control telemetry: CONTINUE_TELEMETRY_ENABLED for PostHog events and CONTINUE_METRICS_ENABLED for OTLP metrics, with smarter DNS checks and warnings when telemetry is blocked. Addresses Linear CON-4878.

  • Migration

    • PostHog: use CONTINUE_TELEMETRY_ENABLED=1|0; falls back to CONTINUE_ALLOW_ANONYMOUS_TELEMETRY if unset.
    • OTLP metrics: use CONTINUE_METRICS_ENABLED=1|0; falls back to CONTINUE_CLI_ENABLE_TELEMETRY and still requires OTEL_* endpoints.
  • Bug Fixes

    • Treat DNS resolutions to 0.0.0.0 and 127.* as blocked and skip telemetry.
    • Show a clear warning when telemetry is blocked by the network.
    • Add tests for blocked and valid DNS cases.

Written for commit 64dbb9a. Summary will update automatically on new commits.

@uinstinct uinstinct requested a review from a team as a code owner November 28, 2025 13:12
@uinstinct uinstinct requested review from tingwai and removed request for a team November 28, 2025 13:12
@continue
Copy link
Contributor

continue bot commented Nov 28, 2025

Keep this PR in a mergeable state →

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 28, 2025
@continue
Copy link
Contributor

continue bot commented Nov 28, 2025

Documentation Updates

Added documentation for the new telemetry environment variables:

Changes made:

  • extensions/cli/spec/telemtry.md: Added CONTINUE_TELEMETRY_ENABLED as the primary variable for controlling PostHog telemetry, with CONTINUE_ALLOW_ANONYMOUS_TELEMETRY noted as legacy but still supported
  • extensions/cli/spec/otlp-metrics.md: Added CONTINUE_METRICS_ENABLED as the primary variable for controlling OTLP metrics collection, with CONTINUE_CLI_ENABLE_TELEMETRY noted as legacy but still supported

Both new variables:

  • Take precedence over the legacy variables
  • Support explicit 1 (enable) and 0 (disable) values
  • Provide more intuitive naming aligned with their purpose

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant