Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not crop symbol that is completely below cell #1639

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

Yaraslaut
Copy link
Member

@Yaraslaut Yaraslaut commented Oct 20, 2024

Closes #1603

Some fonts want underscore character to be below grid cell completely, we can allow

@github-actions github-actions bot added the VT: rasterizer Rendering of the terminal into a pixmap using `terminal_renderer` library label Oct 20, 2024
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thank you

@Yaraslaut Yaraslaut merged commit 3c2f95a into master Oct 21, 2024
30 of 31 checks passed
@Yaraslaut Yaraslaut deleted the fix/undersoce_crop branch October 21, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VT: rasterizer Rendering of the terminal into a pixmap using `terminal_renderer` library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long character and underscore is cut off when font size is set to 12
2 participants