Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Webpack bundle to Rollup + Generate cjs & esm bundle #270

Closed
wants to merge 2 commits into from

Conversation

Pompette
Copy link

@Pompette Pompette commented Mar 27, 2021

This package does not work with snowpack, there was some issues with the current bundle where it does not expose all exports.
I've changed the way of bundling, removed webpack and generate es6 & cjs modules with rollup instead

@yocontra
Copy link
Owner

yocontra commented Mar 28, 2021

@Pompette Did you try with the latest beta release or is this not working with the current stable?

Also, your PR changes the author of the package - check the diff and make sure nothing is in there that isn't needed.

@Pompette
Copy link
Author

Pompette commented Mar 28, 2021

@contra This is what I get with lastest stable version 8.2.0
image

This is what I get with latest beta version react-responsive@9.0.0-beta.1
image

And changing bundle so it use es6 module is working pretty fine 👍
Thanks for the review, I made modification for author, I'm up for other modification if you see something else 💃

Fix url
@devinrhode2
Copy link

I'm guessing this might improve the bundle sizes, but I'm curious by how much?

@yocontra yocontra requested a review from kid-icarus July 14, 2021 23:41
@yocontra
Copy link
Owner

@Pompette Can you test with the latest 9.0.0-beta.3 release?

@BrianL3
Copy link

BrianL3 commented Sep 19, 2021

I'm currently experiencing this very problem. Any news on when this PR will be accepted?

@BrianL3
Copy link

BrianL3 commented Sep 19, 2021

Oh, this issue is resolved with the v9.0.0-beta.4 release. Thanks.

@yocontra
Copy link
Owner

Going to close this since it seems the issue has been resolved with the existing beta, and I haven't heard back from @Pompette in a while.

@yocontra yocontra closed this Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants