Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the default configuration schema for the umbrella DI extension #23

Merged
merged 3 commits into from Sep 9, 2019

Conversation

@Roman3349
Copy link
Contributor

Roman3349 commented Aug 7, 2019

Fixes #22.

Signed-off-by: Roman Ondráček ondracek.roman@centrum.cz

Signed-off-by: Roman Ondráček <ondracek.roman@centrum.cz>
@f3l1x

This comment has been minimized.

Copy link
Member

f3l1x commented Aug 17, 2019

Thanks @Roman3349. Can you please add extra test for it? To know that everything works just fine.

@f3l1x

This comment has been minimized.

Copy link
Member

f3l1x commented Aug 30, 2019

ping @Roman3349

@Roman3349

This comment has been minimized.

Copy link
Contributor Author

Roman3349 commented Sep 2, 2019

@f3l1x This week I'll try add tests.

Signed-off-by: Roman Ondráček <ondracek.roman@centrum.cz>
if ($config->purge === []) {
$config->purge = Helpers::expand(['%tempDir%/cache'], $builder->parameters);
if (!isset($config['purge']) || ($config['purge'] === [])) {
$config['purge'] = Helpers::expand(['%tempDir%/cache'], $builder->parameters);

This comment has been minimized.

Copy link
@mabar

mabar Sep 8, 2019

Member

Why did you change stdClass to array?

This comment has been minimized.

Copy link
@Roman3349

Roman3349 Sep 8, 2019

Author Contributor

I have changed stdClass to array because the default configuration (when extensions are only registered) is an empty array. Another option is explicitly use stdClass as default value in ConsoleBridgesExtension::getConfigSchema.

Signed-off-by: Roman Ondráček <ondracek.roman@centrum.cz>
@Roman3349 Roman3349 requested a review from mabar Sep 8, 2019
@f3l1x f3l1x merged commit 5b1515b into contributte:master Sep 9, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@f3l1x

This comment has been minimized.

Copy link
Member

f3l1x commented Sep 9, 2019

Well done. @Roman3349

@f3l1x

This comment has been minimized.

Copy link
Member

f3l1x commented Sep 9, 2019

Thanks.

@f3l1x

This comment has been minimized.

Copy link
Member

f3l1x commented Sep 9, 2019

@mabar Bump please new version 0.5.1 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.