Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Console registration in not CLI mode #12

Closed
wants to merge 2 commits into from

Conversation

3 participants
@mabar
Copy link
Member

commented Mar 2, 2018

Console is useful in not CLI for running commands through ArrayInput. Without Console\Application is impossible to do proper deployment to servers, where is CLI access not available. https://github.com/modette/http-maintenance#usage---with-nette-framework-symfony-console-and-dgftp-deployment

@f3l1x

This comment has been minimized.

Copy link
Member

commented Mar 2, 2018

It should not be enabled by default. I am thinking about cliOnly, sapiOnly, mode: sapi/all.

@mabar

This comment has been minimized.

Copy link
Member Author

commented Mar 2, 2018

Ok, fixed by mabar/Console@ceb888c

mabar added some commits Mar 2, 2018

@enumag
Copy link
Contributor

left a comment

It seems you have used spaces for indentation instead of tabs.

@f3l1x

This comment has been minimized.

Copy link
Member

commented Apr 6, 2018

Thank you @mabar for this PR. 👍 We'll finish it in #14.

@f3l1x f3l1x closed this Apr 6, 2018

@f3l1x f3l1x added the enhancement label Apr 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.