Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Php7.1, updated coding style, removed deprecated AbstractCommand #16

Merged
merged 5 commits into from Jun 21, 2018

Conversation

2 participants
@mabar
Copy link
Member

commented Jun 20, 2018

Closes #13

@mabar mabar requested a review from f3l1x Jun 20, 2018

@mabar mabar force-pushed the php7.1 branch from ae018f0 to da38101 Jun 20, 2018

@@ -12,18 +18,23 @@
}
],
"require": {
"php": ">= 5.6",
"php": ">= 7.1",
"symfony/console": "^3.2.0 || ^4.0.0"

This comment has been minimized.

Copy link
@f3l1x

f3l1x Jun 20, 2018

Member

I would drop 3.x console.

<rule ref="vendor/ninjify/coding-standard/ruleset.xml"/>
<!-- Contributte Coding Standard -->
<rule ref="./vendor/ninjify/coding-standard/contributte.xml">
<exclude name="SlevomatCodingStandard.Operators.DisallowIncrementAndDecrementOperators.DisallowedPostIncrementOperator"/>

This comment has been minimized.

Copy link
@f3l1x

f3l1x Jun 20, 2018

Member

Is this rule used here?

This comment has been minimized.

This comment has been minimized.

Copy link
@mabar

mabar Jun 21, 2018

Author Member

I could rewrite foreach to use array keys instead

This comment has been minimized.

Copy link
@f3l1x

f3l1x Jun 21, 2018

Member

It's OK. Thanks.

namespace Contributte\Console\Helper;
use Nette\DI\Container;
use Symfony\Component\Console\Helper\Helper;
/**
* @author Milan Felix Sulc <sulcmil@gmail.com>
* @author Filip Procházka <filip@prochazka.su>
* @deprecated
*/
class ContainerHelper extends Helper

This comment has been minimized.

Copy link
@f3l1x

f3l1x Jun 20, 2018

Member

Yep, drop it.

@mabar mabar force-pushed the php7.1 branch from e8a7a49 to c8c5463 Jun 21, 2018

{
$builder = $this->getContainerBuilder();
$config = $this->validateConfig($this->defaults);
// Skip if isn't CLI
if ($this->cliMode !== TRUE) return;
if ($this->cliMode !== true)

This comment has been minimized.

Copy link
@f3l1x

f3l1x Jun 21, 2018

Member

Could you please keep it on same row?

{
$builder = $this->getContainerBuilder();
$config = $this->validateConfig($this->defaults);
// Skip if isn't CLI
if ($this->cliMode !== TRUE) return;
if ($this->cliMode !== true)

This comment has been minimized.

Copy link
@f3l1x

f3l1x Jun 21, 2018

Member

Same above

This comment has been minimized.

Copy link
@mabar

mabar Jun 21, 2018

Author Member

I always accidentally run autoformating and not found yet how to disable that in phpstorm, sorry

This comment has been minimized.

Copy link
@f3l1x

f3l1x Jun 21, 2018

Member

No problem ;-)

@f3l1x f3l1x merged commit 9ad9eb8 into master Jun 21, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@f3l1x f3l1x deleted the php7.1 branch Jun 21, 2018

@f3l1x f3l1x added this to the v0.5 milestone Jun 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.