Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acquisition: Arachne #2

Open
f3l1x opened this issue Mar 24, 2018 · 5 comments

Comments

3 participants
@f3l1x
Copy link
Member

commented Mar 24, 2018

After the long time, we're going to adopt some Arachne packages. :-)

Thanks @enumag, @mabar

Packages:

Package Standalone Package Status
Arachne/Codeception yes contributte/codeception done
Arachne/ServiceCollections no contributte/di next

@f3l1x f3l1x referenced this issue Apr 22, 2018

Closed

Roadmap 2018 #3

@mabar

This comment has been minimized.

Copy link
Member

commented Nov 30, 2018

@enumag

service collections - I've seen that you discussed about them with David in nette/di#178. Are they still required or did you found new nette features good enough?

security and verifier - I was thinking about these packages for a long time. I found that I love them and I am grateful for them.
But I have one which I would like to implement before moving these into Contributte.
It's a return of Nette\Security\User. I understand reasons why it's not used but I think we cannot simply drop it.
It is required by Nette\Application\UI\Presenter::(store|restore)Request and I don't see an easy way how to reimplement these methods.
Solution would be in interface for nette user, just with getId(). In that way we could have our own user which would be also a storage for all its identities.
It would also simplify my use case where I have a single user which is verified against multiple firewalls.

@enumag

This comment has been minimized.

Copy link

commented Nov 30, 2018

@mabar I didn't watch recent nette/di changes. Is the thing dg come up with in that discussion about accessors for multiple services implemented? If it is then ServiceCollections are no longer necessary (or only for Arachne/Forms) and the packages can be adapted to use the new nette/di features.

As for store/restoreRequest in my opinion the usage of user in these methods is completely unnecessary. I really didn't need User for anything in my CMS.

In any case a "User" is a value object with data about the person using the system and therefore should not be a service. If you feel something like Nette\Security\User is necessary then so be it but for gods sake please rename it.

@mabar

This comment has been minimized.

Copy link
Member

commented Dec 1, 2018

Seems like it is implemented. But I am not sure, if it supports get($foo) or just getFoo(); getBar(); nette/di@94a66aa

User in (re)storeRequest is used as a security element. It prevents from sending anyone a link with stored url.

@enumag

This comment has been minimized.

Copy link

commented Dec 1, 2018

User in (re)storeRequest is used as a security element. It prevents from sending anyone a link with stored url.

The requests are stored in your session so the link would not work anyway.

@enumag

This comment has been minimized.

Copy link

commented Dec 1, 2018

Seems like it is implemented. But I am not sure, if it supports get($foo) or just getFoo(); getBar(); nette/di@94a66aa

I believe that's a completely unrelated feature. It's just a sort of "multifactory". Honestly I have no idea what that would be good for. Anyway it can't work as a replacement for ServiceCollections resolvers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.