Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session filter: Filter not found when modifying grid columns #389

Closed
dakorpar opened this Issue Oct 11, 2016 · 4 comments

Comments

3 participants
@dakorpar
Copy link
Member

dakorpar commented Oct 11, 2016

I know what's issue there, but I'm just wondering is it really neccessary to throw exception for this?
As live project always changes you have to modify your grids as well, and then you need to clear session data for all users, probably easiest solution would be to change grid name, but what I'm thinking is that maybe this should be silent error, maybe just ignore that field and continue on, like this is little bit annoying...
Thoughts?

@juniwalk

This comment has been minimized.

Copy link
Collaborator

juniwalk commented Oct 11, 2016

I am 👍 for this, had multiple issues with this.

//cc: @paveljanda

@paveljanda

This comment has been minimized.

Copy link
Member

paveljanda commented Oct 11, 2016

Sure, the datagrid can silently drop the session value and continue executing script.

@juniwalk juniwalk self-assigned this Oct 11, 2016

@juniwalk

This comment has been minimized.

Copy link
Collaborator

juniwalk commented Oct 11, 2016

@dakorpar Could you post the exception here please? I jumped on the opportunity to fix this and now I don't know how to replicate the issue. :D

@dakorpar

This comment has been minimized.

Copy link
Member Author

dakorpar commented Oct 12, 2016

You can reproduce this by just changing column name in grid,
so first sort/filter by that field, change column name in grid and refresh the page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.