Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error, unrecognized expression: .datagrid-tree-item[data-id=] #395

Closed
attreid opened this Issue Oct 17, 2016 · 9 comments

Comments

3 participants
@attreid
Copy link
Contributor

attreid commented Oct 17, 2016

When datagrid uses string as id and id contains character '.', JS throwing

Syntax error, unrecognized expression: .datagrid-tree-item[data-id=]

For fix change line https://github.com/ublaboo/datagrid/blob/master/assets/src/datagrid.coffee#L376
to

children_block = $('.datagrid-tree-item[data-id="' + id + '"]').find('.datagrid-tree-item-children').first()
@juniwalk

This comment has been minimized.

Copy link
Collaborator

juniwalk commented Oct 17, 2016

Could you send pull request?

@juniwalk juniwalk added the bug label Oct 17, 2016

@attreid

This comment has been minimized.

Copy link
Contributor Author

attreid commented Oct 17, 2016

Should I fix just coffee script or coffee and compile js and min.js?

@juniwalk

This comment has been minimized.

Copy link
Collaborator

juniwalk commented Oct 17, 2016

@attreid Please, compile JS too. Thanks!

@attreid

This comment has been minimized.

Copy link
Contributor Author

attreid commented Oct 17, 2016

I sent PR

paveljanda added a commit that referenced this issue Oct 17, 2016

Fix issue #395 (#396)
Fix issue #395
@juniwalk

This comment has been minimized.

Copy link
Collaborator

juniwalk commented Oct 17, 2016

Fixed in #396 by a89ca8b.

@juniwalk juniwalk closed this Oct 17, 2016

@attreid

This comment has been minimized.

Copy link
Contributor Author

attreid commented Oct 18, 2016

Can you release stable version?

@juniwalk

This comment has been minimized.

Copy link
Collaborator

juniwalk commented Oct 18, 2016

@attreid We are making changes to release new major version. As we currently do not branch major versions we can't.

//cc: @paveljanda

@paveljanda

This comment has been minimized.

Copy link
Member

paveljanda commented Oct 18, 2016

@attreid You can use your own fork for now and when new version (v5.0.0.) is released, you can switch back to the original repo.

@attreid

This comment has been minimized.

Copy link
Contributor Author

attreid commented Oct 18, 2016

ok, no problem, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.