Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 4 Support #416

Closed
igorpocta opened this Issue Nov 12, 2016 · 17 comments

Comments

9 participants
@igorpocta
Copy link

igorpocta commented Nov 12, 2016

Add the render file for Bootstrap 4

@juniwalk

This comment has been minimized.

Copy link
Collaborator

juniwalk commented Nov 12, 2016

Hello, I think it would be little premature. Bootstrap 4 has been in alpha for over a year if I remember correctly. I would not hurry this up.

Ofcourse @paveljanda could have something else in mind.

@juniwalk juniwalk added the question label Nov 12, 2016

@paveljanda

This comment has been minimized.

Copy link
Member

paveljanda commented Nov 15, 2016

@igorpocta Please reopen this issue when Bootstrap4 is stable.

@paveljanda paveljanda closed this Nov 15, 2016

@JanGalek

This comment has been minimized.

Copy link
Contributor

JanGalek commented Oct 23, 2017

beta 2 now ;)

@martinvenus

This comment has been minimized.

Copy link

martinvenus commented Nov 30, 2017

I think that beta2 is nearly stable. Could you please consider implementation?

@paveljanda

This comment has been minimized.

Copy link
Member

paveljanda commented Nov 30, 2017

@martinvenus Can you prepare a PR and send it to me when Bootstrap 4 is ready? :)
How much will be html structure and classes affected? Can we keep current template or is it necessary to create a new one for bs 4?

@paveljanda

This comment has been minimized.

Copy link
Member

paveljanda commented Nov 30, 2017

@martinvenus @radekdostal Cool. So you know how to begin. :) There is probably necessary to keep more template files with more theme-specific CSS.

@paveljanda paveljanda reopened this Jan 11, 2018

@paveljanda

This comment has been minimized.

Copy link
Member

paveljanda commented Jan 11, 2018

@igorpocta @JanGalek @martinvenus @radekdostal
Bootstrap 4 support is in branch bootstrap-4 (contains todays newest release 5.5.0). THe only thing left is bootstrap-select for filter MultiSelect which is waiting for its author. As he says - it is already implemented and should be released soon (snapappointments/bootstrap-select#1135).

@paveljanda paveljanda added enhancement and removed question labels Jan 11, 2018

@caseyjhol

This comment has been minimized.

Copy link

caseyjhol commented Feb 13, 2018

Bootstrap 4 support has officially been added as a part of v1.13.0-beta, available here: https://github.com/snapappointments/bootstrap-select/releases/tag/v1.13.0-beta. Please post any issues in that repo from now on. Hoping for a quick beta.

@martinvenus

This comment has been minimized.

Copy link

martinvenus commented Jun 5, 2018

@paveljanda bootstrap-select has been already released. Could you please merge bootstrap-4 branch to master? Thanks :)

@f3l1x

This comment has been minimized.

Copy link
Member

f3l1x commented Jul 7, 2018

Ping @paveljanda ;-)

@f3l1x f3l1x added this to the v5.7 milestone Jul 7, 2018

@f3l1x f3l1x referenced this issue Jul 7, 2018

Closed

Bump v5.7.0 #680

@paveljanda

This comment has been minimized.

Copy link
Member

paveljanda commented Jul 9, 2018

@f3l1x It can be merged. It's just that I haven't tested yet the new bootstrap-select with bs4. Have anyone here tested it yet? Does it work correctly?

There should be also some changes in frontend dependecies, right?

@jaroslavlibal

This comment has been minimized.

Copy link
Contributor

jaroslavlibal commented Aug 13, 2018

We are using this branch with:

  • "bootstrap": "^4.1.3"
  • "bootstrap-datepicker": "^1.8.0"
  • "bootstrap-select": "^1.13.1"
  • "jquery": "^3.3.1"

I think it works pretty fine, but there could be some workaronds I dont know about in our code as frontend is not my job.

@martinvenus

This comment has been minimized.

Copy link

martinvenus commented Sep 17, 2018

Is there any progress pls? @jaroslavlibal mentioned that we are using this branch without any problem.

@martinvenus

This comment has been minimized.

Copy link

martinvenus commented Sep 24, 2018

It seems that it takes more time to merge this branch to master. Could you please merge current master to this branch?

@f3l1x

This comment has been minimized.

Copy link
Member

f3l1x commented Sep 29, 2018

Bootstrap 4 is merged to v5.x.

#700
#699

@f3l1x f3l1x closed this Sep 29, 2018

@martinvenus

This comment has been minimized.

Copy link

martinvenus commented Oct 2, 2018

It seems that there is some problem with updating v5.x-dev (https://packagist.org/packages/ublaboo/datagrid#v5.x-dev) on packagist. Last commit there is "e7cacbe" but should be "29915f0". Could you please check it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.