Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape column identifier in DibiFluentDataSource #386

Merged
merged 1 commit into from Oct 17, 2016

Conversation

3 participants
@dakorpar
Copy link
Member

dakorpar commented Oct 6, 2016

When using SQL keyword as column name, in my case 'key', you'll get SQL syntax error when filtering with that column. This fixes it.

@paveljanda

This comment has been minimized.

Copy link
Member

paveljanda commented Oct 9, 2016

@dakorpar Travis says your PR s broken.. Can you please chat it out? Thanks!

@dakorpar

This comment has been minimized.

Copy link
Member Author

dakorpar commented Oct 10, 2016

@paveljanda that's really wierd, tests are passing and code is working perfectly well
screenshot_3
I see what problem could be, it's different version of dibi, but tests are running on my pc, why?
I can solve it by using old deprecated dibi 2 function escape

@dakorpar dakorpar force-pushed the dakorpar:escape-column-name branch from c1b60a7 to a8520da Oct 10, 2016

@juniwalk juniwalk merged commit 9045e2d into contributte:master Oct 17, 2016

2 checks passed

Scrutinizer 1 new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dakorpar dakorpar deleted the dakorpar:escape-column-name branch Oct 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.