Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sorting by date #390

Merged
merged 2 commits into from Oct 13, 2016

Conversation

4 participants
@schneidermichal
Copy link
Contributor

schneidermichal commented Oct 11, 2016

No description provided.

@juniwalk

This comment has been minimized.

Copy link
Collaborator

juniwalk commented Oct 11, 2016

@schneidermichal Hello, could you please use instanceof instead of is_a function?

@paveljanda

This comment has been minimized.

Copy link
Member

paveljanda commented Oct 13, 2016

@schneidermichal Could you please squash these commits? Thanks!

@schneidermichal

This comment has been minimized.

Copy link
Contributor Author

schneidermichal commented Oct 13, 2016

Done. I'm sorry.

@paveljanda

This comment has been minimized.

Copy link
Member

paveljanda commented Oct 13, 2016

@schneidermichal Could you please squash these commits? Thanks!

@juniwalk

This comment has been minimized.

Copy link
Collaborator

juniwalk commented Oct 13, 2016

@paveljanda You should be able to squash them when merging! :) Click the arrow!

@dakorpar

This comment has been minimized.

Copy link
Member

dakorpar commented Oct 13, 2016

That should save us a lot of troubles, many times when doing force push PR automatically closes.

@paveljanda

This comment has been minimized.

Copy link
Member

paveljanda commented Oct 13, 2016

@dakorpar Never happened to me.

@paveljanda paveljanda merged commit 244919c into contributte:master Oct 13, 2016

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@paveljanda

This comment has been minimized.

Copy link
Member

paveljanda commented Oct 13, 2016

@schneidermichal Thank you.

@dakorpar

This comment has been minimized.

Copy link
Member

dakorpar commented Oct 14, 2016

@paveljanda maybe doesn't happen to owners of repository.
I'll check my PR I think in few of them actually wroted PR closed because of push --force

@juniwalk

This comment has been minimized.

Copy link
Collaborator

juniwalk commented Oct 14, 2016

@dakorpar I have been force pushing to PRs to this repository multiple times, never closed on me.

@paveljanda

This comment has been minimized.

Copy link
Member

paveljanda commented Oct 14, 2016

@dakorpar Never happened to me when updating pull requests (Not my repos). You can "google" some tutorials on youtube, maybe you will find something there

@schneidermichal

This comment has been minimized.

Copy link
Contributor Author

schneidermichal commented Oct 14, 2016

I made the fix directly to master branch, as I found, making feature branch would be better...

@dakorpar

This comment has been minimized.

Copy link
Member

dakorpar commented Oct 14, 2016

well there's not much there you either squash them with rebase -i and hash of first commit you want to take set all other commits to squash and force push (never really works for me), or you can do it git reset --soft hash, so I don't really see what could go wrong and why PR was automatically closed... Could be something with my setup or something... Maybe I went one commit to far...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.