Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable multi-sort capability; Closes #391 #405

Merged
merged 1 commit into from Nov 2, 2016

Conversation

2 participants
@juniwalk
Copy link
Collaborator

juniwalk commented Nov 1, 2016

See issue #391 for more details.

@juniwalk juniwalk added this to the v5.0 milestone Nov 1, 2016

@juniwalk juniwalk force-pushed the multi-sort branch from ea14693 to d59dfc5 Nov 1, 2016

$column = $this->columns[$key];
$new_sort = [$key => $value];
} catch (DataGridColumnNotFoundException $e) {
unset($sort[$key]);

This comment has been minimized.

@juniwalk

juniwalk Nov 1, 2016

Author Collaborator

@paveljanda Budem ignorovat neexistující sloupce, nebo budem vyhazovat chybu?

This comment has been minimized.

@paveljanda

paveljanda Nov 1, 2016

Member

Ignoroval bych.

* @return array
* @internal
*/
public function getSortNext(\Ublaboo\DataGrid\Column\Column $column)

This comment has been minimized.

@juniwalk

juniwalk Nov 1, 2016

Author Collaborator

@paveljanda Jak tu funkci pojmenujem?

This comment has been minimized.

@paveljanda

paveljanda Nov 1, 2016

Member

Tu getSortNext? Vždyť jsi jí pojmenoval...?

This comment has been minimized.

@juniwalk

juniwalk Nov 1, 2016

Author Collaborator

Špatně jsem to napsal, necháme to takto, nebo bys tu fci přímo nad DataGrid classou pojmenoval jinak? Hádám že necháme.

This comment has been minimized.

@paveljanda

paveljanda Nov 1, 2016

Member

Joo, třeba takhle.

@juniwalk

This comment has been minimized.

Copy link
Collaborator Author

juniwalk commented Nov 1, 2016

@paveljanda Mám ještě nějak implementovat tu fci na možnost vypnutí multi-sortu? S tou methodou DataGrid::getSortNext() to bude lehké.

@juniwalk juniwalk force-pushed the multi-sort branch from d59dfc5 to 0e14306 Nov 2, 2016

@juniwalk juniwalk force-pushed the multi-sort branch from 0e14306 to f6f1477 Nov 2, 2016

@juniwalk juniwalk merged commit 515177c into master Nov 2, 2016

3 checks passed

Scrutinizer 11 new issues, 3 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@juniwalk juniwalk deleted the multi-sort branch Nov 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.