Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor getAttribtues to getAttributes #408

Merged
merged 1 commit into from Nov 2, 2016

Conversation

2 participants
@dakorpar
Copy link
Member

dakorpar commented Nov 2, 2016

I didn't see any usage of deprecated on datagrid, but I used default nette way there...
Maybe we can add in which version this will be removed completelly

@juniwalk

This comment has been minimized.

Copy link
Collaborator

juniwalk commented Nov 2, 2016

Great job! Thanks!

@juniwalk juniwalk merged commit c3fb723 into contributte:master Nov 2, 2016

2 checks passed

Scrutinizer 1 new issues, 1 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@juniwalk

This comment has been minimized.

Copy link
Collaborator

juniwalk commented Nov 2, 2016

I used this method to improve #393 so there is no BC break for next version. Thanks for inspiration.

@juniwalk juniwalk added the deprecate label Nov 2, 2016

@juniwalk juniwalk added this to the v5.0 milestone Nov 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.