Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic support for related column names #413

Merged
merged 1 commit into from Dec 4, 2016

Conversation

3 participants
@PingusPepan
Copy link
Contributor

PingusPepan commented Nov 5, 2016

Added basic support for syntax $grid->addColumnType('name', 'Title', ':related_table.column') when using Nette Database

Basic support for related column names
Added basic support for syntax $grid->addColumnType('name', 'Title', ':related_table.column')
@dakorpar

This comment has been minimized.

Copy link
Member

dakorpar commented Nov 5, 2016

I believe all features has to be supported for all datasources or it won't get implemented at all,
since this is preety specific for Nette database this should be (IMHO) solved in different approach...

@PingusPepan

This comment has been minimized.

Copy link
Contributor Author

PingusPepan commented Nov 5, 2016

@dakorpar The dot in column name is now supported only for doctrine (here and here). That's why I added this for Nette Database. I don't know how related tables are handled in different datasources.

@PingusPepan

This comment has been minimized.

Copy link
Contributor Author

PingusPepan commented Nov 5, 2016

Seems to work fine for me. Why not test and merge this if there are no problems and add the feature for all datasources somewhere in the future? I don't see any downsides to this approach other than only the users of Nette Database would benefit from this

@dakorpar

This comment has been minimized.

Copy link
Member

dakorpar commented Nov 5, 2016

Well its question for paveljanda and juniwalk, but IMHO problem then is documentation (seperate for every datasource instead on interface level), and if you switch datasource your grid should work same way, I mean all classes using same interface should return same result, but they can have different implementation. If only doctrine has something different then other datasources then thats also wrong IMHO, just my two cents...

@dakorpar

This comment has been minimized.

Copy link
Member

dakorpar commented Nov 5, 2016

Well on other hand since theres no new public functions there, that would not work on different datasources there is no much damage, so could be ok...

@paveljanda

This comment has been minimized.

Copy link
Member

paveljanda commented Nov 13, 2016

@PingusPepan Can you please add some tests? I will merge it then.

@paveljanda paveljanda added this to the v5.0 milestone Nov 13, 2016

@paveljanda

This comment has been minimized.

Copy link
Member

paveljanda commented Nov 16, 2016

@PingusPepan Ping. are you able to add some tests? There are only one remaining issue and this pull-request to complete v5.0 milestone. We will release a new version (v5.0.0) then.

@PingusPepan

This comment has been minimized.

Copy link
Contributor Author

PingusPepan commented Nov 16, 2016

@paveljanda paveljanda merged commit 96dc684 into contributte:master Dec 4, 2016

1 of 2 checks passed

Scrutinizer Errored
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.