Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't change collation when searching in DibiFluent #428

Merged
merged 1 commit into from Dec 14, 2016

Conversation

3 participants
@dakorpar
Copy link
Member

dakorpar commented Dec 8, 2016

For me search on this way works much better. I can live with forcing utf8_general_ci
But I don't see a point switching to utf8_bin when some UTF8 character is in search?
Any explanation, or anything else? It's wierd now that search become case sensitive immidiatelly when utf-8 character appear, not to mention completelly different behavior...

@ingig

This comment has been minimized.

Copy link

ingig commented Dec 8, 2016

@dakorpar so what´s the solution to make it case insensitive?

@dakorpar

This comment has been minimized.

Copy link
Member Author

dakorpar commented Dec 8, 2016

@ingig This is repo for ublaboo datagrid we're using. Here is pull request that resolves this, I'll see if we can get solution directly in datagrid (PR must be accepted, or something changed) or we will have to add this to our own DataSource class, would be better to have it in datagrid directly...

@dakorpar

This comment has been minimized.

Copy link
Member Author

dakorpar commented Dec 10, 2016

@paveljanda this is quick one, can you provide some input here?
IMHO datagrid shouldn't force any collation here, user choosed his html encoding, user choosed his database encoding, IMHO datagrid shouldn't do anything here...

@juniwalk

This comment has been minimized.

Copy link
Collaborator

juniwalk commented Dec 14, 2016

@dakorpar Hello, @paveljanda is currently away for few days. As I agree with you I will merge this. Pavel can fix it if he has different idea.

Thanks.

@juniwalk juniwalk merged commit 8ad5920 into contributte:master Dec 14, 2016

2 checks passed

Scrutinizer 1 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dakorpar dakorpar deleted the dakorpar:search branch Feb 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.