Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable column translating #435

Merged
merged 5 commits into from Dec 27, 2016

Conversation

2 participants
@schneidermichal
Copy link
Contributor

schneidermichal commented Dec 23, 2016

No description provided.

@paveljanda

This comment has been minimized.

Copy link
Member

paveljanda commented Dec 23, 2016

@schneidermichal Great idea, can you provide some tests please?

@schneidermichal

This comment has been minimized.

Copy link
Contributor Author

schneidermichal commented Dec 23, 2016

@paveljanda I'll try it ;-)

@schneidermichal

This comment has been minimized.

Copy link
Contributor Author

schneidermichal commented Dec 23, 2016

@paveljanda Unfortunately, I don't know how to test column header rendering...

@paveljanda

This comment has been minimized.

Copy link
Member

paveljanda commented Dec 24, 2016

@schneidermichal Just one last thing: it is all about column header localization, co can you name the methods and properties more like setTranslatableHeader() and $translatable_header?

@paveljanda

This comment has been minimized.

Copy link
Member

paveljanda commented Dec 27, 2016

Perfect, thanks!

@paveljanda paveljanda merged commit fc75684 into contributte:master Dec 27, 2016

2 checks passed

Scrutinizer 2 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.