Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DoctrineDataSource: use Paginator only when needed #506

Merged
merged 1 commit into from Mar 24, 2017

Conversation

2 participants
@vitkutny
Copy link
Contributor

vitkutny commented Mar 24, 2017

Paginator is used only if join/groupBy is used in query. For simple data without join it is unnecessarily slow AF.

DoctrineDataSource: use Paginator only when needed
Paginator is used only if join/groupBy is used in query. For simple data without join it is unnecessarily slow AF.

@juniwalk juniwalk merged commit 719c4a6 into contributte:v5.x Mar 24, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@juniwalk

This comment has been minimized.

Copy link
Collaborator

juniwalk commented Mar 24, 2017

Great job! Thank you :)

@vitkutny vitkutny deleted the vitkutny:doctrine-data-source-paginator branch Mar 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.