Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show column with checkboxes when group actions is defined. #516

Merged
merged 3 commits into from Apr 19, 2017

Conversation

2 participants
@radekprokes
Copy link
Contributor

radekprokes commented Apr 13, 2017

Fixed issue #472

@juniwalk

This comment has been minimized.

Copy link
Collaborator

juniwalk commented Apr 19, 2017

@proki Hey, is it necessary to call $control->hasGroupActions() all the time? Calling method is slower than comparing variable.

@radekprokes

This comment has been minimized.

Copy link
Contributor Author

radekprokes commented Apr 19, 2017

My mistake, I fixed it :)

@juniwalk

This comment has been minimized.

Copy link
Collaborator

juniwalk commented Apr 19, 2017

Great, now just resolve the conflicts :)

@radekprokes

This comment has been minimized.

Copy link
Contributor Author

radekprokes commented Apr 19, 2017

Resolved.

@juniwalk juniwalk merged commit 3e62fd9 into contributte:v5.x Apr 19, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@juniwalk

This comment has been minimized.

Copy link
Collaborator

juniwalk commented Apr 19, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.