Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NextrasDataSource: MultiSelect fix #653

Merged
merged 1 commit into from Oct 29, 2018

Conversation

3 participants
@martenb
Copy link
Contributor

martenb commented Apr 26, 2018

Should fix #623

@f3l1x

This comment has been minimized.

Copy link
Member

f3l1x commented Jul 7, 2018

Could you please rebase it on current v5.x? Thanks.

@martenb martenb force-pushed the martenb:v5.x branch from 5550fe9 to b1e3ea0 Jul 9, 2018

@martenb

This comment has been minimized.

Copy link
Contributor Author

martenb commented Jul 10, 2018

Done.

@f3l1x

This comment has been minimized.

Copy link
Member

f3l1x commented Jul 10, 2018

Could you please review it @paveljanda?

@paveljanda

This comment has been minimized.

Copy link
Member

paveljanda commented Sep 19, 2018

@martenb I know I am writing late, but could you add tests for this datasource and modified method? Thanks you!

@martenb

This comment has been minimized.

Copy link
Contributor Author

martenb commented Sep 25, 2018

I just coppied code from standard Select, this is tested i Datasource itself...

@paveljanda

This comment has been minimized.

Copy link
Member

paveljanda commented Oct 5, 2018

Ok, I think it is ready for merge

@f3l1x f3l1x merged commit 4ab6a21 into contributte:v5.x Oct 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@f3l1x f3l1x added this to the v5.8 milestone Oct 29, 2018

@f3l1x

This comment has been minimized.

Copy link
Member

f3l1x commented Oct 29, 2018

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.