Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed return annotation #659

Merged
merged 1 commit into from May 23, 2018

Conversation

3 participants
@radekprokes
Copy link
Contributor

radekprokes commented May 22, 2018

No description provided.

@paveljanda

This comment has been minimized.

Copy link
Member

paveljanda commented May 22, 2018

@radekprokes This method returns only static (return $this)

@radekprokes

This comment has been minimized.

Copy link
Contributor Author

radekprokes commented May 22, 2018

I know, so I fixed it so and removed the bad callable annotation

@f3l1x

This comment has been minimized.

Copy link
Member

f3l1x commented May 22, 2018

I know it's not part of this PR, but could you please drop PHP 7.2 in Travis? There's unrelated misusage in nextras/orm which failing on PHP 7.2.

@paveljanda

This comment has been minimized.

Copy link
Member

paveljanda commented May 22, 2018

@radekprokes Oh I see, I was confused by the diff colors..
@f3l1x Let's make another PR for that.. #660

@f3l1x f3l1x merged commit 1838f47 into contributte:v5.x May 23, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@f3l1x f3l1x added this to the v5.7 milestone May 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.